This repository has been archived by the owner on Nov 14, 2019. It is now read-only.
Encode and decode Hashes from and to base58 #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasMahe
changed the title
NicolasMahe
commented
Aug 30, 2019
| @@ -56,7 +58,12 @@ export default abstract class extends Command { | |||
| styledJSON(data: any) { | |||
| const {flags} = this.parse() | |||
| if (flags.silent) return | |||
| cli.styledJSON(data) | |||
| const base58EncodedHash = JSON.parse(JSON.stringify(data, (key: string, value: any): any => { | |||
There was a problem hiding this comment.
If somebody has a better way instead of JSON.parse(JSON.stringify, please implement it :)
NicolasMahe
commented
Aug 30, 2019
|
I'm not sure it is some part forgotten so just checking
Is that normal? Anyway I will work more on it for the new compilation so I will be able to test/fix that |
antho1404
approved these changes
Aug 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://github.com/mesg-foundation/cli/issues/137
Related to https://github.com/mesg-foundation/mesg-js/issues/123 and mesg-foundation/engine#1265.
Because of mesg-foundation/engine#1270, hashes are now in bytes instead of string over the gRPC API.
This PR update the CLI to use mesg-js version of mesg-foundation/mesg-js#124 and encode / decode the hash properly.